Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): useIonModal/useIonPopover dismiss accepts data and role #25209

Merged
merged 5 commits into from
Apr 29, 2022

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

You can pass back data or role information in the dismiss function for both the modal and popover usage of hooks.

Issue URL: #25208

What is the new behavior?

You can pass data and role information in the dismiss function.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 6.1.4-dev.11651091997.1bc6fa6b

Updated reproduction with the dev-build: https://stackblitz.com/edit/react-1udk9j?file=main.js

@sean-perkins sean-perkins requested a review from a team as a code owner April 27, 2022 20:54
@github-actions github-actions bot added the package: react @ionic/react package label Apr 27, 2022
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants