Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): card modal can now be swiped to close on the content #25185

Merged
merged 22 commits into from
Apr 27, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Apr 25, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #22046

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 6.1.3-dev.11650647187.10053e0b

@liamdebeasi liamdebeasi requested a review from a team as a code owner April 25, 2022 15:24
@github-actions github-actions bot added the package: core @ionic/core package label Apr 25, 2022
@averyjohnston
Copy link
Contributor

I'm unable to swipe the modal closed on the new card-scroll-target test; should I be able to? I'm testing on both my PC (Windows Chrome 100.0.4896.127) and my phone (Android 12 Chrome). I've tried swiping on both the header and the content.

@liamdebeasi
Copy link
Contributor Author

Are you testing in MD mode or iOS mode? The card modal is only available in iOS mode.

@averyjohnston
Copy link
Contributor

Aha, that explains it 😆 Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: swipe to close modal from content
4 participants