-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datetime): arrow navigation respects min/max values #25182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
suggested changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write some tests?
averyjohnston
approved these changes
Apr 26, 2022
liamdebeasi
approved these changes
May 2, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The value of the
ion-datetime
, when used withmin
ormax
, can incorrectly disable the next/previous navigation. When selecting a date such as "March 20th, 2022", but having a max date of "April 19th, 2022"; the existing comparison logic would disable the next button, since the 1 month offset was April 20th, which was beyond the max value. The same behavior happened for min values.Issue URL: #25073
What is the new behavior?
When calculating if the next or previous button should be disabled, it will ignore comparison on the day of the month and only compares if the month & year are within bounds (for next/previous navigation).
Does this introduce a breaking change?
Other information
Dev-build:
6.1.3-dev.11650654723.120c74ee
✅Reproduction repo: https://github.com/sean-perkins/ion-datetime-min-max-25073 (uses dev build).