Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): arrow navigation respects min/max values #25182

Merged
merged 14 commits into from
May 2, 2022
Merged

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Apr 24, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The value of the ion-datetime, when used with min or max, can incorrectly disable the next/previous navigation. When selecting a date such as "March 20th, 2022", but having a max date of "April 19th, 2022"; the existing comparison logic would disable the next button, since the 1 month offset was April 20th, which was beyond the max value. The same behavior happened for min values.

Issue URL: #25073

What is the new behavior?

When calculating if the next or previous button should be disabled, it will ignore comparison on the day of the month and only compares if the month & year are within bounds (for next/previous navigation).

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 6.1.3-dev.11650654723.120c74ee

Reproduction repo: https://github.com/sean-perkins/ion-datetime-min-max-25073 (uses dev build).

@sean-perkins sean-perkins requested a review from a team as a code owner April 24, 2022 23:46
@github-actions github-actions bot added the package: core @ionic/core package label Apr 24, 2022
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write some tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants