fix(select): avoid duplicate dialogs and backdrops when clicking #25175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Rapidly clicking an
ion-select
can produce multipleion-alert
and backdrops. This is because the internal state flag is only set after the overlay is created (before presenting). You can produce this reliably by manually calling.click()
multiple times on the same element reference.Issue URL: #25126
What is the new behavior?
Sets the flag prior to the overlay being created, this prevents multiple alert/backdrops from being presented.
Does this introduce a breaking change?
Other information
Dev-build:
6.1.3-dev.11650650446.100eff34
🟨