Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): avoid duplicate dialogs and backdrops when clicking #25175

Merged
merged 6 commits into from
Apr 26, 2022

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Rapidly clicking an ion-select can produce multiple ion-alert and backdrops. This is because the internal state flag is only set after the overlay is created (before presenting). You can produce this reliably by manually calling .click() multiple times on the same element reference.

Issue URL: #25126

What is the new behavior?

Sets the flag prior to the overlay being created, this prevents multiple alert/backdrops from being presented.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 6.1.3-dev.11650650446.100eff34 🟨

@sean-perkins sean-perkins requested a review from a team as a code owner April 22, 2022 18:30
@github-actions github-actions bot added the package: core @ionic/core package label Apr 22, 2022
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to merging let's also update the commit subject. Select doesn't only present alert dialogs, so the current message is confusing.

Maybe something like:

fix(select): avoid duplicate dialogs when clicking

@sean-perkins sean-perkins changed the title fix(select): prevent multiple alert windows fix(select): avoid duplicate dialogs and backdrops when clicking Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants