Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: canDismiss is missing in modal interface #25143

Closed
4 of 6 tasks
EinfachHans opened this issue Apr 18, 2022 · 3 comments
Closed
4 of 6 tasks

bug: canDismiss is missing in modal interface #25143

EinfachHans opened this issue Apr 18, 2022 · 3 comments
Assignees
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@EinfachHans
Copy link
Contributor

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

The new canDismiss from #24928 is missing in the ModalOptions interface:

Bildschirmfoto 2022-04-18 um 12 46 15

Expected Behavior

It should be add 😃

Steps to Reproduce

No need i guess

Code Reproduction URL

No response

Ionic Info

.

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Apr 18, 2022
@sean-perkins sean-perkins added package: core @ionic/core package type: bug a confirmed bug report labels Apr 18, 2022
@sean-perkins sean-perkins self-assigned this Apr 18, 2022
@ionitron-bot ionitron-bot bot removed the triage label Apr 18, 2022
@sean-perkins
Copy link
Contributor

Thanks @EinfachHans!

Could you test with this dev-build and let me know if all the types are coming through as expected?

6.1.2-dev.11650303569.14bacac1

@EinfachHans
Copy link
Contributor Author

@sean-perkins canDismiss is available in the dev build , yes 🎉

@ionitron-bot
Copy link

ionitron-bot bot commented May 19, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants