Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right side menu not showing when expose-aside-when=large #2328

Closed
jasonvillalon opened this issue Oct 1, 2014 · 21 comments
Closed

Right side menu not showing when expose-aside-when=large #2328

jasonvillalon opened this issue Oct 1, 2014 · 21 comments
Assignees
Milestone

Comments

@jasonvillalon
Copy link

menu-toggle="right" is not working when expose-aside-when="large" is added in ion-side-menus

http://plnkr.co/w0aJln?p=preview2

@drewrygh drewrygh added the menus label Oct 1, 2014
@mikkokam
Copy link

Also, adding expose-aside-when to a right side menu will not expose it.
Instead, it leads to the left menu being exposed (even though the expose-aside-when directive is not in it).

@FelixLC
Copy link

FelixLC commented Oct 30, 2014

Yes, the directive should be related to ion-side-menu, not ion-side-menu s. It should be possible to have both side menus open when working on a large screen

@dabroek
Copy link

dabroek commented Dec 18, 2014

+1

@dabroek
Copy link

dabroek commented Dec 20, 2014

Quick fix to enable toggling the right sidebar is to change line 47667 in the bundle from:

if (isAsideExposed || !self.right.isEnabled) return;

to:

if (!self.right.isEnabled) return;

@claude
Copy link

claude commented Feb 16, 2015

+1

1 similar comment
@apostoiis
Copy link

+1

@manosim
Copy link

manosim commented Mar 13, 2015

Not sure if this one is related to #3244 which is ready for RC1.

@mhartington mhartington added this to the 1.0.0-rc4 milestone Apr 16, 2015
@mhartington
Copy link
Contributor

Still seeing this with the nightly build builds.

http://plnkr.co/edit/Dlpeu10XiESQnBHYiz3z?p=preview

@helmut-hoffer-von-ankershoffen

+1 to get this fixed.

@danboh
Copy link

danboh commented Jul 20, 2015

+1 any workaround on this?

@lucbonnin
Copy link

+1 to get it fix please. really anoying issue

@lucbonnin
Copy link

I think it is a HUGE issue for ergonomic purpose for several use cases :

  • when you have both sides menus with only leftMenu expose-aside-when=large, you can't access the right side menu :(
  • when you want your ipad to display side menus + content pane all the time.

Do you have any idea of a duedate for this issue on ionic v1 ?
I think it is not hard to fix it and some guys suggested some pull request.

@numerized
Copy link

Hi There, Issue still present.

@mlynch mlynch closed this as completed in a98f88b Dec 7, 2015
@mlynch
Copy link
Contributor

mlynch commented Dec 7, 2015

Hey everyone, got this fixed :) Behavior will look like this:

screenshot 2015-12-06 19 16 32

🍻

@doorty
Copy link

doorty commented Jan 13, 2016

I think the desired behavior is for each side menu to have their own exposeAside that are independent of each other. For instance, I just want the left menu to open when "large" and not the right side.

@davidbergvik
Copy link

+1 doorty, the current fix exposes both the left and right menu if one of them has expose-aside-when set.

@felly
Copy link

felly commented Mar 17, 2016

In my opinion this fix also reopens #3352 as the element's width doesn't get updated after an orientation change (a98f88b#diff-7f8a45a06c53978f6e2571220899a0eaR178).

@MuhammadRashed
Copy link

fixed:

in the file: ionic.bundle.js
change the code:

setTranslateX: ionic.animationFrameThrottle(function(amount) {
var xTransform = content.offsetX + amount;
$element[0].style[ionic.CSS.TRANSFORM] = 'translate3d(' + xTransform + 'px,0,0)';

change it to be:

setTranslateX: ionic.animationFrameThrottle(function(amount) {
var xTransform = content.offsetX + amount;
if (content.offsetX > 0)
{
      xTransform = amount;
}
$element[0].style[ionic.CSS.TRANSFORM] = 'translate3d(' + xTransform + 'px,0,0)';

I know this is not good solution but I had to.

@yossi-shasho
Copy link

+1 for a fix

@axsaucedo
Copy link

+1

@chaitanyagupta76
Copy link

above fix is not working any help on this is highly appreciated

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests