-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: cannot use IonItem with IonRouter on React-Tests #22986
Comments
Sorry, the |
@liamdebeasi Unfortunately I just got an error and I still can't fix it :(
|
For 1) make sure you have run For 2) follow these steps:
The steps here are not the most intuitive, so I can document these somewhere in the readme. |
@liamdebeasi It works now. It has to be like this:
Unfortunately on my MacBook |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Bug Report
Ionic version:
[ ] 4.x
[x] 5.x
Current behavior:
Cannot use IonItem with IonRouter on React Tests at "/packages/react/test/test-app/". Getting error:
Property 'routerAnimation' is missing in type '{ children: Element[]; button: true; }' but required in type 'Pick<IonItem, "color" | "button" | "disabled" | "lines" | "mode" | "href" | "routerAnimation" | "rel" | "target" | "download" | "type" | "detail" | "detailIcon">'. TS2741
Expected behavior:
IonRouter should get the property routerAnimation.
Steps to reproduce:
See steps: #22342 (comment)
Related code:
https://github.com/ionic-team/ionic-framework/tree/master/packages/react/test/test-app
Other information:
Issue #22342 cannot be fixed without testing and fixing this issue..
Ionic info:
Cannot give ionic info because of working in the Source Code of Ionic Framework.
The text was updated successfully, but these errors were encountered: