Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Multiple Side-Menu Bug #20701

Closed
Aupourbau opened this issue Mar 5, 2020 · 5 comments
Closed

bug: Multiple Side-Menu Bug #20701

Aupourbau opened this issue Mar 5, 2020 · 5 comments
Labels

Comments

@Aupourbau
Copy link

Bug Report

Ionic version:
@ionic/react": "5.0.0

Current behaviour:
Simple two pages app, each of them has a specific menu.
In Page 1:

  • Open Menu 1 (using swipe right or toggle button)
  • Close Menu 1 (using swipe right or toggle button)
  • Go to Page 2

In Page 2:

  • Open Menu 2 (using swipe right or toggle button)
  • Close Menu 2 (using swipe right or toggle button)
  • Go to Page 1

In Page 1:

  • Open Menu 1 using toggle button --> Nothing happens
  • Open Menu 1 using swipe right --> After a few tries getting this error:
    animation-56279521.js:608 Uncaught TypeError: Failed to set the 'currentTime' property on 'Animation': The provided double value is non-finite.
    at animation-56279521.js:608
    at Array.forEach ()
    at setAnimationStep (animation-56279521.js:607)
    at Object.progressStep (animation-56279521.js:695)
    at animation-56279521.js:693
    at Array.forEach ()
    at Object.progressStep (animation-56279521.js:692)
    at class_1.onMove (ion-menu_3-md.entry.js:335)
    at onMove (ion-menu_3-md.entry.js:119)
    at fireOnMove (index-c38df685.js:482)

Expected behaviour:
Expecting the menu to open when coming back to a page

Related code:
Code to reproduce the behaviour at below link:
https://github.com/Aupourbau/ionic-multiple-side-menu-bug

If you can let me know what is wrong with my code of fix the bug if it is on your side, it would great!

Thanks!

@ionitron-bot ionitron-bot bot added the triage label Mar 5, 2020
@Aupourbau
Copy link
Author

I was finally able to fix the issue by using Lifecycle events and setting the menus status to disabled or not.
Repo is also updated with the fix

@martinkasa
Copy link

martinkasa commented Mar 12, 2020

I had this issue also in Ionic v4.
My scenario:

  • open menu on page 1 -> works
  • navigate to page 2 - menu on page 2 -> works
  • navigate BACK to page 1 - open menu on page 1 -> does not work anymore

After some debugging I find out "disabled" property on menu1 was set to true after navigation to page 2, BUT even after navigating back to page 1 "disabled" was not restored to false, so menu 1 stopped to work at all.

ion-split-pane is also affected by this.

As you said, workaround is to manually set "disabled" property of ion-menu to false in some lifecycle hook.

@longgt
Copy link

longgt commented Mar 16, 2020

#15916

@ionic-team ionic-team deleted a comment from PAVDSSVD Jan 5, 2022
@ionic-team ionic-team deleted a comment from PAVDSSVD Jan 5, 2022
@liamdebeasi
Copy link
Contributor

Thanks for the issue and apologies for the delay. There are a couple known issues with using multiple side menus in an Ionic app. #18974 and #18683 are the main ones.

The GitHub repo provided in the original post no longer exists, and I am not able to reproduce this behavior with the latest version of Ionic 6. I am going to close this issue. If you are still running into this problem please create a new issue and include a GitHub repo that we can use to verify this behavior. Thank you!

@ionitron-bot
Copy link

ionitron-bot bot commented Jun 3, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants