Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in ionic-angluar.js #1582

Closed
ctaepper opened this issue Jun 6, 2014 · 3 comments
Closed

bug in ionic-angluar.js #1582

ctaepper opened this issue Jun 6, 2014 · 3 comments
Assignees

Comments

@ctaepper
Copy link

ctaepper commented Jun 6, 2014

line 166 should read

scope.cancel();

instead of

opts.cancel();
@perrygovier perrygovier self-assigned this Jun 6, 2014
@perrygovier
Copy link
Contributor

Hey @ctaepper, opts.cancel() is a valid method there, and an appropriate one too.

Calling scope.cancel() would trigger an infinite loop if you click the cancel button directly and not just the background overlay.

Gonna close this, but let me know if you're seeing a but related to this.

@ajoslin
Copy link
Contributor

ajoslin commented Jun 6, 2014

This is being fixed through #1576

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants