-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular variables (super short) visible in side menu on iOS 7.1 since nightly-1712 #1188
Comments
Hi rvanbaalen! What version of ios is the iPhone 4 running? |
@ajoslin iOS 7.1 & Ionic nightly |
This issue is happening on all iOS devices. Not only iPhone 4. It's just performing very poorly lately which is causing the flickering of these 'binding variables' (or whatever they are called). |
What kind of markup are you using to make it lag? In my tests, it seems to be performing well. Is your performance bottleneck elsewhere? are you doing any dom manipulation or changes when the side menu changes? |
One of the heaviest pages I have in my app is the one with a leaflet map in it. It has a structure like this:
In other words: it's a map in a tab and the tabs in a side menu content area with left and right menus. The loading of the Leaflet map has some heavy impact on the apps performance (map starts initialising while the side menu is still animating the close event) but this was never ān issue before. On the iPhone 4 it's somewhat acceptable that things are running a little slow but I never saw these variables showing anywhere before I installed the latest nightly build. I must add that I'm seeing the plain text variables only in my side menu when it's closing. The menu item labels and For instance this is one of my menu items:
And this is a part of the menu item array in my controller's scope:
Hope this helps |
@ajoslin I've done some extensive testing today on this issue and my conclusion is that this 'flickering' started with Care to shed some light on what happend between those two releases? From what I've read on the interwebz this issue can be triggered by a faulty digest cycle in Angular. For example it seems to be bad practice to use |
Hi @rvanbaalen. Sorry for slow responses, we've all been in our caves working on specific features (I've been working on virtual scroll). nightly-1712 is when we implemented the tap/touch refactor. However, things showing up uncompiled sounds like a very unrelated problem. Interesting ... Could you post your side menus' whole markup? |
It's ok, the slow response. I've been able to get an acceptable working version of Ionic now so I'm happy! I just needed to implement the ugly hack mentioned here #1137 (comment) to get taps on map markers working. For now I'm just going to stick to I hope this bug report and the pin-pointing to |
I'm glad you have a stable release! I hope your app does exceedingly well. |
@ajoslin Unfortunately it's an app for our client's members (requiring a username and password) otherwise I would have shared it when it launches in the app stores (Android and iOS) |
I still can't reproduce this. When you have a sec, could you post your full markup? Thanks =) |
Closing for now. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
On an iPhone 4, I get to see the original Angular binding variables (e.g.
{{ menuItemLabel }}
) when the side menu is closing.This didn't happen before and my app didn't change so I'm assuming its something being caused by a recent release on the master branch.
When clicking a menu item, I'm updating the state. Are there many calculations going on lately which are affecting the performance on older devices? On an iPhone 5 or Galaxy S3 / S4 the performance is pretty good. I can only reproduce this on an iPhone 4.
Update
This issue is reproducible on both an iPhone 4 and 5 running iOS 7.1 and has been around starting from
nightly-1712
The text was updated successfully, but these errors were encountered: