Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No left margin on action-sheet-icon in RTL #11650

Closed
DMan577 opened this issue May 13, 2017 · 6 comments
Closed

No left margin on action-sheet-icon in RTL #11650

DMan577 opened this issue May 13, 2017 · 6 comments

Comments

@DMan577
Copy link

DMan577 commented May 13, 2017

Ionic version: (check one with "x")
[x] 3.x

I'm submitting a ... (check one with "x")
[x] bug report

Current behavior:
2

Expected behavior:
A margin between the icon and the text:
3

Steps to reproduce:
Simply create an action sheet with some items while in RTL.

@AmitMY
Copy link
Contributor

AmitMY commented May 13, 2017

@DMan577 Fixed in #11342
Will be released in the next version, most likely 3.3.0.

@brandyscarney Please close

@DMan577 DMan577 closed this as completed May 13, 2017
@eyas2n
Copy link

eyas2n commented Dec 4, 2017

Issue still there.

@AmitMY
Copy link
Contributor

AmitMY commented Dec 4, 2017

@eyas2n I remember fixing this..
Are you on “$direction: multi”?

@eyas2n
Copy link

eyas2n commented Dec 6, 2017

Just implemented it and it's working fine for actionsheet. What about side menu sliding direction, should I open a separate issue for that?

@AmitMY
Copy link
Contributor

AmitMY commented Dec 6, 2017

There is an open issue, and even a fix for runtime menu direction changes, but it was not merged.
For now, you need to do platform.setDir('rtl') before the menu is loaded into DOM (what I do when users switch languages, is refresh the page, and set it right in the AppComponent's constructor..

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 1, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants