Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-searchbar bug on 3.1.0, 3.1.1, 3.2.0 for non-latin languages. #11566

Closed
kelvinhokk opened this issue May 9, 2017 · 18 comments · Fixed by #11586
Closed

ion-searchbar bug on 3.1.0, 3.1.1, 3.2.0 for non-latin languages. #11566

kelvinhokk opened this issue May 9, 2017 · 18 comments · Fixed by #11586

Comments

@kelvinhokk
Copy link

kelvinhokk commented May 9, 2017

Ionic version: (check one with "x")
[ ] 1.x
[ ] 2.x
[ X] 3.x

I'm submitting a ... (check one with "x")
[X ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:

Replication environment: Mac OS X (for PWA)
Different behaviours in Chrome 58.0.3029.96 and Safari Version 10.1 (12603.1.30.0.34) (see videos)

Currently I have replicated the bug on the ionic-preview-app on ionic versions 3.1.1, 3.1.0, 3.2.0

The bug does not happen on 3.0.1.

Description: The key up on the ion-searchbar seems to be broken since 3.1.0 onwards for non latin keyboards. For example I am using a chinese Hanyu pin yin keyboard to type "青山" (qingshan).

However on Safari, the ion-searchbar goes like "qqqiqiqingqinqingqing sqing sqing shqing... ". See video.
On Chrome, the ion-searchbar seems to dismiss the language bar intended to popup.

Expected behavior:

The ion-searchbar should work normally with the different language inputs.

See video.

Steps to reproduce:

  1. check out and build the ionic-preview-app and build

  2. ionic serve

  3. scroll to the ion-searchbar page.

  4. change input to chinese and type "qingshan". notice on Chrome the input for chinese does not appear, and on Safari multiple letters appear.

  5. Change package.json ionic-angular dependency to 3.0.1

  6. remove node_modules and npm install again

  7. notice that things work normally.

Related code:

insert any relevant code here

https://github.com/driftyco/ionic-preview-app

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

insert the output from ionic info here

Cordova CLI: 6.5.0
Ionic Framework Version: 3.0.1 (or 3.1.1 for the bug)
Ionic CLI Version: 2.2.2
Ionic App Lib Version: 2.2.1
Ionic App Scripts Version: 1.3.5
ios-deploy version: 1.9.1
ios-sim version: 5.0.2
OS: macOS Sierra
Node Version: v7.9.0

bug on safari
Bug on ion-searchbar on 3.1.0 and 3.1.1

expected behaviour
Expected behaviour

@jgw96 jgw96 added accessibility and removed v2 labels May 9, 2017
@jgw96
Copy link
Contributor

jgw96 commented May 9, 2017

Hello, thanks for using Ionic! We will look into this.

@miz-k
Copy link

miz-k commented May 10, 2017

I've also encountered the same symptom after using 3.1.0. when ion-searchbar had worked correctly with 2.x

@kelvinhokk kelvinhokk changed the title ion-searchbar bug on 3.1.0 and 3.1.1 for non-latin languages. ion-searchbar bug on 3.1.0, 3.1.1, 3.2.0 for non-latin languages. May 11, 2017
@nishizhen
Copy link

nishizhen commented May 18, 2017

we have the same bug~~~~

But , this bug just fire on IOS and IOS simulator .
Android works fine!

@puku0x
Copy link

puku0x commented May 18, 2017

I faced the same bug too during inputting Japanese.

I could solve this by replacing from (input) to (change) in https://github.com/driftyco/ionic/blob/master/src/components/searchbar/searchbar.ts#L37 .

@woodstream
Copy link

I had compared this version3.0.1 and version3.2.1 that I found to modify this function "Searchbar.prototype._inputUpdated" can fixed it

@jgw96
Copy link
Contributor

jgw96 commented Jun 1, 2017

Hello all! This is going to be fixed in the next release of ionic in this pr #11586

@danielsogl
Copy link
Contributor

@jgw96 you linked to an issue ^^

@DavidRyu123
Copy link

@jgw96 It has a android and web issue too. When I type a Korean in ion-searchbar element, Korean alphabets show ㄱㅏㄴㅏㄱㄷㅏㄱ where it should be 가낙닥.
Would you look into this issue too?
Thanks.

global packages:

@ionic/cli-utils : 1.3.0
Cordova CLI      : 7.0.1 
Ionic CLI        : 3.3.0

local packages:

@ionic/app-scripts              : 1.3.7
@ionic/cli-plugin-cordova       : 1.3.0
@ionic/cli-plugin-ionic-angular : 1.3.0
Cordova Platforms               : android 6.2.3 ios 4.4.0
Ionic Framework                 : ionic-angular 3.3.0

System:

Node       : v7.7.2
OS         : macOS Sierra
Xcode      : Xcode 8.3.1 Build version 8E1000a 
ios-deploy : 1.9.1 
ios-sim    : 5.0.6 

@road1987
Copy link

road1987 commented Jun 6, 2017

I faced the same problem too . when i am using chinese input method in input[text] . Looks like model would not change after blur event happen on the input box. If using english input method first , there is no problem .

@woodstream
Copy link

it had fixed on 3.4.0

@lxieyang
Copy link

@woodstream I'm still facing the same issue.

@KevinHongSpigit
Copy link

Still getting error with 3.4.0

@tscislo
Copy link

tscislo commented Aug 30, 2017

@DavidRyu123 did you managed to solve your problem? Was that fixed in recent version?

@DavidRyu123
Copy link

@tscislo yep. It's solved with update.

@tscislo
Copy link

tscislo commented Aug 30, 2017

Thanks it works for me as well in 3.4.2

@skygragon
Copy link

I'm using 3.19.1, but still have this issue on IOS.

@FdezRomero
Copy link
Contributor

@skygragon That's the version for the Ionic CLI, you have to update ionic-angular on your project:

npm install ionic-angular@latest --save

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 1, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 1, 2018
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report and removed package: core @ionic/core package type: bug a confirmed bug report labels Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.