Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic 3.1.0 Menu Output Events Error #11383

Closed
badger-ua opened this issue Apr 26, 2017 · 4 comments
Closed

Ionic 3.1.0 Menu Output Events Error #11383

badger-ua opened this issue Apr 26, 2017 · 4 comments

Comments

@badger-ua
Copy link

Ionic version: (check one with "x")
[ ] 1.x
[ ] 2.x
[x] 3.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
image

Expected behavior:
In Ionic 3.0.1 Menu Output Events worked as expected.

Related code:

let menu = this.menuCtrl.get('menu');

   if (menu) {
     this.subscription.add(menu.ionOpen.subscribe(() => {
       this.map.setClickable(false);
     }));

     this.subscription.add(menu.ionClose.subscribe(() => {
       if (this.autocompleteSelected)
         this.map.setClickable(true);
       else return;
     }));
   }

Other information:
Errors:

  1. Property 'ionOpen' does not exist on type 'Menu'.
  2. Property 'ionClose' does not exist on type 'Menu'.

Maybe I'm overlooking something? I've just updated 3.0.1 to 3.1.0 and this error came out, I'm running the same code, I was at 3.0.1

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Ionic Framework Version: 3.1.0
Ionic CLI Version: 2.2.2
Ionic App Lib Version: 2.2.1
Ionic App Scripts Version: 1.3.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v7.8.0
Xcode version: Not installed

P.S: It's my first time opening issue, hope i've done everything correct, if not, please sorry :)

@jgw96 jgw96 added the v3 label Apr 26, 2017
@jgw96
Copy link
Contributor

jgw96 commented Apr 26, 2017

Hello, great first issue and welcome to the Ionic Github! We will look into this regression.

@rapropos
Copy link
Contributor

I think this was caused by the shift of Menu to an interface in 59eb9a3.

@badger-ua
Copy link
Author

@rapropos That's true, thank you very much :)

I'll stick with this fix for now: https://github.com/Nikoz47/ionic/commit/0e0bf3a015352850fa6e8789fe5870082eb2b29d

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants