Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Pane Component sizing settable via SASS variables #10893

Closed
chrisgriffith opened this issue Mar 23, 2017 · 3 comments
Closed

Split Pane Component sizing settable via SASS variables #10893

chrisgriffith opened this issue Mar 23, 2017 · 3 comments
Milestone

Comments

@chrisgriffith
Copy link
Contributor

The min and max widths for the split pane are hard coded. Would like to have those values be settable via SASS variables

@brandyscarney
Copy link
Member

Sure, @manucorporat let's call these:

$split-pane-ios-side-min-width
$split-pane-ios-side-max-width

https://github.com/driftyco/ionic/blob/master/src/components/split-pane/split-pane.ios.scss#L10

Thoughts?

@chrisgriffith
Copy link
Contributor Author

Don't forget the other two platforms ;) Do we want to have a global set of variables for this, as well as platform specific?

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants