Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS avatar in item not configurable #10763

Closed
Sh1d0w opened this issue Mar 14, 2017 · 2 comments
Closed

iOS avatar in item not configurable #10763

Sh1d0w opened this issue Mar 14, 2017 · 2 comments
Assignees
Milestone

Comments

@Sh1d0w
Copy link

Sh1d0w commented Mar 14, 2017

Ionic version: (check one with "x")
[ ] 1.x
[ x ] 2.x

I'm submitting a ... (check one with "x")
[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:

This commit introduced hardcoded value for the border radius of the img

e84f2e2#diff-b71116393e7fd80818fc01a903f68082R173

Which makes circle images with content out of the circle to appear cut.

Expected behavior:

Solution: make the border radius property configurable via sass variable. So in this case I can set the value to 0px without having to override it with !important in my css files ...

Steps to reproduce:
http://plnkr.co/edit/NZpDBBeduQT2K0IRtJv8?p=preview

Related code:

    <ion-item>
      <ion-avatar item-left>
        <img src="./img.svg">
      </ion-avatar>
      <h2>I am cut</h2>
    </ion-item>

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

Your system information:

    Cordova CLI: 6.4.0 
    Ionic Framework Version: 2.2.0
    Ionic CLI Version: 3.0.0-beta.4
    ios-deploy version: 1.9.0 
    ios-sim version: 5.0.13 
    OS: macOS Sierra
    Node Version: v7.7.1
    Xcode version: Xcode 8.2.1 Build version 8C1002

cc @brandyscarney

@brandyscarney brandyscarney self-assigned this Mar 14, 2017
@brandyscarney brandyscarney added this to the 3.1 milestone Apr 6, 2017
@brandyscarney
Copy link
Member

Thanks for the issue! I released a nightly version that includes this [email protected]. It is based off of the 3.x version here: https://github.com/driftyco/ionic/blob/master/CHANGELOG.md#300-2017-04-05

To install and test it:

npm install --save --save-exact [email protected]

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants