Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading controller not working properly in the latest nightly #10654

Closed
Sh1d0w opened this issue Mar 5, 2017 · 2 comments
Closed

Loading controller not working properly in the latest nightly #10654

Sh1d0w opened this issue Mar 5, 2017 · 2 comments
Assignees
Milestone

Comments

@Sh1d0w
Copy link

Sh1d0w commented Mar 5, 2017

Ionic version: (check one with "x")
[ ] 1.x
[ x ] 2.x

I'm submitting a ... (check one with "x")
[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:

When you create and dismiss two loading components one after another, the second one is never dismissed, no matter if you use .dismiss() or .dismissAll()

Expected behavior:

The loading component is dismissed properly.

Steps to reproduce:

  1. npm install ionic-angular@nightly

Related code:

    let loading = this.loadingCtrl.create({});
 
    loading.present();
 
    loading.dismiss();

    let loading2 = this.loadingCtrl.create({});
 
    loading2.present();
 
    loading2.dismiss();

This was working ok on stable 2.1.0

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

Your system information:

Cordova CLI: 6.4.0 
Ionic Framework Version: 2.1.0-201703032024
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.4
ios-deploy version: 1.9.0 
ios-sim version: 5.0.13 
OS: macOS Sierra
Node Version: v7.7.1
Xcode version: Xcode 8.2.1 Build version 8C1002
@manucorporat manucorporat self-assigned this Mar 5, 2017
@manucorporat manucorporat added this to the 2.2.0 milestone Mar 5, 2017
@manucorporat
Copy link
Contributor

Regression introduced by this change:
5a4c609#diff-4fbdcb4f2c1fdfa3a66827a1377c351bL223

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants