Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper clicks on list items while scrolling #1015

Closed
tmiskin opened this issue Apr 2, 2014 · 5 comments
Closed

Improper clicks on list items while scrolling #1015

tmiskin opened this issue Apr 2, 2014 · 5 comments
Assignees
Milestone

Comments

@tmiskin
Copy link

tmiskin commented Apr 2, 2014

List items are clicked while scrolling because of the 'touchcancel' event. This is the issue reported multiple times on the forums. This event is essentially an error event most commonly fired in Android but is seemingly random and will basically hijack the touch event from touch move. This event was being treated as a click in tapPolyfill. I need to fork this to make pull requests some time, but the place I fixed it was line 50 - https://github.com/driftyco/ionic/blob/master/js/utils/tap.js

Changed it to if( isRecentTap(e) || e.type === 'touchcancel') {

This is exactly like the hammer.js issue here - hammerjs/hammer.js#339

And fixed here - hammerjs/hammer.js@1eaef6b

@adamdbradley
Copy link
Contributor

Thanks for debugging this! I'll start testing it out, thanks.

@adamdbradley
Copy link
Contributor

@tmiskin would you be able to verify the updates work in build 1523 or later? Thanks!
http://code.ionicframework.com/#nightly

@tmiskin
Copy link
Author

tmiskin commented Apr 2, 2014

Yes, that fixed it. Thanks Adam!

Hopefully with list improvements those touch cancel events will fire less frequently too. I think the move to chromium as the webview engine in Android is a big culprit.

@adamdbradley
Copy link
Contributor

awesome thanks for debugging this!

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants