-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improper clicks on list items while scrolling #1015
Comments
Thanks for debugging this! I'll start testing it out, thanks. |
@tmiskin would you be able to verify the updates work in build 1523 or later? Thanks! |
Yes, that fixed it. Thanks Adam! Hopefully with list improvements those touch cancel events will fire less frequently too. I think the move to chromium as the webview engine in Android is a big culprit. |
awesome thanks for debugging this! |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
List items are clicked while scrolling because of the 'touchcancel' event. This is the issue reported multiple times on the forums. This event is essentially an error event most commonly fired in Android but is seemingly random and will basically hijack the touch event from touch move. This event was being treated as a click in tapPolyfill. I need to fork this to make pull requests some time, but the place I fixed it was line 50 - https://github.com/driftyco/ionic/blob/master/js/utils/tap.js
Changed it to if( isRecentTap(e) || e.type === 'touchcancel') {
This is exactly like the hammer.js issue here - hammerjs/hammer.js#339
And fixed here - hammerjs/hammer.js@1eaef6b
The text was updated successfully, but these errors were encountered: