From b259ca6a1ff217c1cc7dce7288bd58df2da46691 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 26 Apr 2022 22:43:20 +0545 Subject: [PATCH] ci(lint): ensure linted results are pushed for build to pass (#25196) --- .github/workflows/actions/test-core-lint/action.yml | 7 +++++++ core/src/components/footer/footer.tsx | 1 - core/src/components/infinite-scroll/infinite-scroll.tsx | 1 - core/src/components/modal/modal-interface.ts | 6 +++--- core/src/components/refresher/refresher.tsx | 1 - core/src/components/reorder-group/reorder-group.tsx | 1 - core/src/utils/test/playwright/playwright-page.ts | 8 +------- 7 files changed, 11 insertions(+), 14 deletions(-) diff --git a/.github/workflows/actions/test-core-lint/action.yml b/.github/workflows/actions/test-core-lint/action.yml index f12dd9f3112..eaad989b2c1 100644 --- a/.github/workflows/actions/test-core-lint/action.yml +++ b/.github/workflows/actions/test-core-lint/action.yml @@ -18,3 +18,10 @@ runs: run: npm run lint shell: bash working-directory: ./core + # Lint changes should be pushed + # to the branch before the branch + # is merge eligible. + - name: Check Lint Results + run: git diff --exit-code + shell: bash + working-directory: ./core diff --git a/core/src/components/footer/footer.tsx b/core/src/components/footer/footer.tsx index 62f949c8de0..7e0ae4b9abc 100644 --- a/core/src/components/footer/footer.tsx +++ b/core/src/components/footer/footer.tsx @@ -4,7 +4,6 @@ import { Component, Element, Host, Prop, h } from '@stencil/core'; import { getIonMode } from '../../global/ionic-global'; import { findIonContent, getScrollElement, printIonContentErrorMsg } from '../../utils/content'; - import { handleFooterFade } from './footer.utils'; /** diff --git a/core/src/components/infinite-scroll/infinite-scroll.tsx b/core/src/components/infinite-scroll/infinite-scroll.tsx index c10ce79903a..f2c04fab735 100644 --- a/core/src/components/infinite-scroll/infinite-scroll.tsx +++ b/core/src/components/infinite-scroll/infinite-scroll.tsx @@ -4,7 +4,6 @@ import { Component, Element, Event, Host, Method, Prop, State, Watch, h, readTas import { getIonMode } from '../../global/ionic-global'; import { findClosestIonContent, getScrollElement, printIonContentErrorMsg } from '../../utils/content'; - @Component({ tag: 'ion-infinite-scroll', styleUrl: 'infinite-scroll.scss', diff --git a/core/src/components/modal/modal-interface.ts b/core/src/components/modal/modal-interface.ts index 5c67ddc3eda..d0e635e750f 100644 --- a/core/src/components/modal/modal-interface.ts +++ b/core/src/components/modal/modal-interface.ts @@ -10,9 +10,9 @@ export interface ModalOptions { delegate?: FrameworkDelegate; animated?: boolean; /** - * If `true`, the modal can be swiped to dismiss. Only applies in iOS mode. - * @deprecated - To prevent modals from dismissing, use canDismiss instead. - */ + * If `true`, the modal can be swiped to dismiss. Only applies in iOS mode. + * @deprecated - To prevent modals from dismissing, use canDismiss instead. + */ swipeToClose?: boolean; canDismiss?: boolean | (() => Promise); diff --git a/core/src/components/refresher/refresher.tsx b/core/src/components/refresher/refresher.tsx index 7d90b6fe199..e62342dec90 100644 --- a/core/src/components/refresher/refresher.tsx +++ b/core/src/components/refresher/refresher.tsx @@ -1,7 +1,6 @@ import type { ComponentInterface, EventEmitter } from '@stencil/core'; import { Component, Element, Event, Host, Method, Prop, State, Watch, h, readTask, writeTask } from '@stencil/core'; - import { getIonMode } from '../../global/ionic-global'; import type { Animation, Gesture, GestureDetail, RefresherEventDetail } from '../../interface'; import { getTimeGivenProgression } from '../../utils/animation/cubic-bezier'; diff --git a/core/src/components/reorder-group/reorder-group.tsx b/core/src/components/reorder-group/reorder-group.tsx index 73995e52962..d0b50286335 100644 --- a/core/src/components/reorder-group/reorder-group.tsx +++ b/core/src/components/reorder-group/reorder-group.tsx @@ -1,7 +1,6 @@ import type { ComponentInterface, EventEmitter } from '@stencil/core'; import { Component, Element, Event, Host, Method, Prop, State, Watch, h } from '@stencil/core'; - import { getIonMode } from '../../global/ionic-global'; import type { Gesture, GestureDetail, ItemReorderEventDetail } from '../../interface'; import { findClosestIonContent, getScrollElement } from '../../utils/content'; diff --git a/core/src/utils/test/playwright/playwright-page.ts b/core/src/utils/test/playwright/playwright-page.ts index 6e8e8a9742b..870cb7fe99f 100644 --- a/core/src/utils/test/playwright/playwright-page.ts +++ b/core/src/utils/test/playwright/playwright-page.ts @@ -8,13 +8,7 @@ import type { import { test as base } from '@playwright/test'; import { initPageEvents } from './page/event-spy'; -import { - getSnapshotSettings, - goto as goToPage, - setIonViewport, - spyOnEvent, - waitForChanges, -} from './page/utils'; +import { getSnapshotSettings, goto as goToPage, setIonViewport, spyOnEvent, waitForChanges } from './page/utils'; import type { E2EPage } from './playwright-declarations'; type CustomTestArgs = PlaywrightTestArgs &