Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic hooks add is not using the current version of the hooks scripts #1681

Closed
ekrapfl opened this issue Nov 15, 2016 · 2 comments
Closed

ionic hooks add is not using the current version of the hooks scripts #1681

ekrapfl opened this issue Nov 15, 2016 · 2 comments

Comments

@ekrapfl
Copy link

ekrapfl commented Nov 15, 2016

Short description of the problem:

Running ionic hooks add pulls in the hook scripts, but they appear to be an older version of the scripts.
This is problematic because it causes warnings about using the deprecated sys module. This warning seemed to be causing some of our ios plugins to not install correctly on our build server.

What behavior are you expecting?

I was expecting ionic hooks add to retrieve the current version of the scripts (ie: this
but it appears we are getting this

Steps to reproduce:

  1. Create a new Ionic project with latest CLI version (I am using node 6.9.1, ionic-cli 2.1.8 and cordova 6.4.0)
  2. Run ionic hooks add
  3. Look at the hooks/after_platform_add/010_install_plugins.js file
  4. Notice that this file seems to not be the current version found here
@ekrapfl
Copy link
Author

ekrapfl commented Nov 15, 2016

As a quick update, I have gotten around this by no longer using the hooks scripts. Following what I believe is the direction Ionic is trending, I have moved all of my platform and plugin declarations to the config.xml, where Cordova can handle them all on its own. No hooks required. Has anyone else been dealing with things like this?

Reference Links:
http://stackoverflow.com/questions/30042975/manage-cordova-plugins-with-npm-package-json

#1324

http://stackoverflow.com/questions/33830058/package-json-vs-config-xml-for-cordova-plugins

@ionitron-bot
Copy link

ionitron-bot bot commented Jul 12, 2018

Thanks for the issue! This issue appears to be associated with an old version of the Ionic CLI. Please update to the latest CLI version, which supports all versions of the Ionic Framework. If the issue is relevant and if it persists after updating to the latest CLI version, please create a new issue.

Thank you for using Ionic!

@ionitron-bot ionitron-bot bot closed this as completed Jul 12, 2018
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants