-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relative template and style urls in ionic2 #1196
Comments
From @BenjaminDieter on June 17, 2016 10:55 Ionic uses WebPack, which allows us to use Require: (did not work for me because of missing typings which I didn't want to include) import { Component } from '@angular/core';
@Component({
selector: 'my-app',
template: require('./header.component.html'),
styles: [require('./header.component.css')]
})
export class HeaderComponent implements OnInit {
} Import: import { Component } from '@angular/core';
import { Component } from '@angular/core';
import headerTemplate from './header.component.html';
import headerStyle from './header.component.css';
@Component({
selector : 'my-app',
template : headerTemplate,
styles : [headerStyle]
})
export class HeaderComponent implements OnInit {
} Source: Component-Relative Paths in Angular 2 on ThoughtRam. Thomas Burleson describes how to achieve the ability to use relative paths while using WebPack there. |
Hello @BenjaminDieter we actually use browserify for Ionic 2 (we used to use Webpack). @michaelknoch i will speak with some of our build team and see if they have an answer for this question. Thanks for using Ionic! |
From @michaelknoch on June 17, 2016 22:45 I made some experience with https://github.com/ludohenin/gulp-inline-ng2-template. Maybe rendering referenced templateurl and style files inline is a solution @jgw96 |
From @natevecc on June 19, 2016 13:52 Is there a way this could be handled by the @component's moduleId property instead of inlining the html/css? https://angular.io/docs/ts/latest/api/core/index/ComponentMetadata-class.html#!#moduleId-anchor |
From @441N143G on July 6, 2016 12:43 any news about relative paths? |
Hello all, just a heads up that were changing up our build chain to support minification, tree shaking and offline template compilation, so all this will be changing relatively soon. Once that is done I will be revisiting this issue. Thanks everyone! |
From @vong-xiv on July 7, 2016 18:41 @jgw96 this is a pain that need to be addressed. example: Let's say a developer has
and here's need to be added into
|
From @mirkonasato on July 20, 2016 7:45 Following. Currently, code generated by
and it's not immediately clear 1. where that |
From @441N143G on July 20, 2016 13:49 yeap, we realy need normal angular2-style with relative paths 4 this. |
+1 |
What's about this issue? I can not use scss file inside html file and I have to set templateUrl.
in the .ts file I have to set up templateUrl, there is no magic finding of html file and there is no way to load scss files for html. Some ideas? |
u can import scss to theme/app.core.scss, like this: |
I found the solution for this, I have to configure the file in core .scss file, uhhh that's ... :0 https://forum.ionicframework.com/t/ionic2-default-starter-ignores-all-sass-files/59005 |
Why was Webpack dropped in favor of Gulp? Maybe this is an interim option, but I dont like that it does so much with your source files: https://www.npmjs.com/package/gulp-angular-embed-templates. Anyway I am all in in auto-relative-hyper loading. We dont need to verbose the crap out of our files. Redundancy sucks. |
+1 for using moduleid to solve relative paths: |
Any updates on this. Should we be seeing a resolution in beta12? |
The generated project now has
so the template path is relative which is great. There's still a |
@mirkonasato Is it being imported in |
@BenjaminDieter there is no |
It looks like SCSS is being brought in as part of the build process (now Rollup-based), watching for SCSS changes in the project and compiling to a main.css file. I'd like to see the relative path used for styles as well, primarily to allow use of Angular's view encapsulation. As is, view encapsulation can be done in Ionic by inlining CSS (using 'styles' prop on Component), but the inline approach has enough drawbacks to keep me from using it. |
@aaronbroad Agreed. The encapsulation is one of the reasons I like Angular2 so much. Not sure why the ionic team decided against it. @jgw96 any updates on the styleUrls? |
Seems like the SCSS rules must match the Component Hence this change in ionic2-starter-tabs I guess. |
I've run into that same issue today. Any update on this ? Can't I use angular2 styleUrls ? |
Any update on this? I really would like to use the styleUrls the right way! |
I agree. Instead of grabbing all the (S)CSS files and generating one big file, why not use the features Angular 2 has? It works great and it's also clear for everyone switching over from vanilla Angular 2 to Ionic 2. At first I was like "What!? Why can't I use the I haven't tested this, but what happens if I happen to have 2 components with the same selector but in different feature modules? Let's assume the selector is So yes, I hope this issue gets a little more attention. |
@component({ In above if I have 3 html files so one will go as selector in above but how do I write other two files in templateUrl |
Why do won't to do this? I think it is better to have one Component so one selector per template. Which are your use case you wan't to have more templates per component? I never used this and I'm also not sure if this is possible, I don't think so! |
@nikhildhar123 That doesn't work. You can only set one template url per component. If you want multiple templates, use one component per template. This has nothing to do with this feature request. |
This issue has been automatically closed because it had the If this issue is still a problem in CLI v3, please create a new issue. Thank you! |
Does it solve the problem? |
From @michaelknoch on June 15, 2016 14:48
is there a possibility to use relative template and style urls for ionic2 components when using browserify bundle?
I am running an angular2 web app using CommonJS and module.id in my components. The plan is to reuse these ng2 components in my ionic application, but i was not able to fix the relative/absolute path problem for now.
Anny suggestions?
Copied from original issue: ionic-team/ionic-framework#6922
The text was updated successfully, but these errors were encountered: