Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

fix(readConfigJson): Setting readConfigJson constant wrong #761

Merged
merged 1 commit into from
Feb 17, 2017
Merged

fix(readConfigJson): Setting readConfigJson constant wrong #761

merged 1 commit into from
Feb 17, 2017

Conversation

vaskou
Copy link
Contributor

@vaskou vaskou commented Feb 17, 2017

Short description of what this resolves:

ENV_READ_CONFIG_JSON constant was being set wrong by resolving --readConfigJson argument as path instead of boolean.
That was causing if statement in line 56 of http-server.ts being always false, so the proxies could not load.

Fixes: #759

@danbucholtz danbucholtz merged commit 64bc17f into ionic-team:master Feb 17, 2017
@danbucholtz
Copy link
Contributor

Thanks @vaskou!

Thanks,
Dan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants