Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

fs-extra/readJsonSync breaks comments in tsconfig.json #18

Closed
rob3c opened this issue Sep 21, 2016 · 2 comments
Closed

fs-extra/readJsonSync breaks comments in tsconfig.json #18

rob3c opened this issue Sep 21, 2016 · 2 comments

Comments

@rob3c
Copy link
Contributor

rob3c commented Sep 21, 2016

TypeScript has allowed comments in tsconfig.json files for almost a year now (see microsoft/TypeScript#4987), but the current use of readJsonSync() in fs-extra to parse tsconfig.json files doesn't seem to like them.

Maybe switching to a tsconfig-aware library like https://github.com/TypeStrong/tsconfig would better support the full format?

@adamdbradley
Copy link
Contributor

Good call, I'll look into it, thanks!

@danbucholtz
Copy link
Contributor

PR welcome here. Otherwise this is off our radar for now.

Thanks,
Dan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants