Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Commit

Permalink
fix(bonjour): remove bonjour as its causing trouble for users on Wind…
Browse files Browse the repository at this point in the history
…ows without git
  • Loading branch information
danbucholtz committed Jun 28, 2017
1 parent af7ac0d commit e4b5c59
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 35 deletions.
28 changes: 0 additions & 28 deletions src/dev-server/bonjour.ts

This file was deleted.

8 changes: 1 addition & 7 deletions src/serve.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import open from './util/open';
import { createNotificationServer } from './dev-server/notification-server';
import { createHttpServer } from './dev-server/http-server';
import { createLiveReloadServer } from './dev-server/live-reload';
import { createBonjourService } from './dev-server/bonjour';
import { ServeConfig, IONIC_LAB_URL } from './dev-server/serve-config';
import { findClosestOpenPorts } from './util/network';

Expand Down Expand Up @@ -47,7 +46,7 @@ export function serve(context: BuildContext) {
useServerLogs: useServerLogs(context),
useProxy: useProxy(context),
notifyOnConsoleLog: sendClientConsoleLogs(context),
devapp: useBonjour(context)
devapp: false
};

createNotificationServer(config);
Expand All @@ -57,7 +56,6 @@ export function serve(context: BuildContext) {
return watch(context);
})
.then(() => {
createBonjourService(config);
onReady(config, context);
return config;
}, (err: BuildError) => {
Expand Down Expand Up @@ -143,10 +141,6 @@ function browserOption(context: BuildContext): string {
return getConfigValue(context, '--browseroption', '-o', 'IONIC_BROWSEROPTION', 'ionic_browseroption', null);
}

function useBonjour(context: BuildContext): boolean {
return hasConfigValue(context, '--devapp', '-D', 'devapp', false);
}

function launchLab(context: BuildContext): boolean {
return hasConfigValue(context, '--lab', '-l', 'ionic_lab', false);
}
Expand Down

0 comments on commit e4b5c59

Please sign in to comment.