fix(diagnostics): fix null pointers

ionic-team · Dec 12, 2016 · 72adc86 · 72adc86
1 parent b6c12f5
commit 72adc86
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/highlight/highlight.ts b/src/highlight/highlight.ts
@@ -154,7 +154,7 @@ function compileLanguage(language: any) {
 
 
 export function highlightError(htmlInput: string, errorCharStart: number, errorLength: number) {
-  if (errorCharStart < 0 || errorLength < 1) return htmlInput;
+  if (errorCharStart < 0 || errorLength < 1 || htmlInput == undefined) return htmlInput;
 
   const chars = htmlInput.split('');
   let inTag = false;

diff --git a/src/logger/logger-diagnostics.ts b/src/logger/logger-diagnostics.ts
@@ -334,7 +334,7 @@ function eachLineHasLeadingWhitespace(lines: PrintLine[], code: 'text'|'html') {
     return false;
   }
   for (var i = 0; i < lines.length; i++) {
-    if ((<any>lines[i])[code].length < 1) {
+    if (lines[i][code] == undefined || (<any>lines[i])[code].length < 1) {
       return false;
     }
     var firstChar = (<any>lines[i])[code].charAt(0);

diff --git a/src/logger/logger-typescript.ts b/src/logger/logger-typescript.ts
@@ -53,7 +53,7 @@ function loadDiagnostic(context: BuildContext, tsDiagnostic: ts.Diagnostic) {
       errorLength: Math.max(tsDiagnostic.length, 1)
     };
 
-    if (errorLine.html.indexOf('class="hljs') === -1) {
+    if (errorLine.html && errorLine.html.indexOf('class="hljs') === -1) {
       try {
         errorLine.html = highlight(d.language, errorLine.text, true).value;
       } catch (e) {}
@@ -78,7 +78,7 @@ function loadDiagnostic(context: BuildContext, tsDiagnostic: ts.Diagnostic) {
         errorLength: -1
       };
 
-      if (previousLine.html.indexOf('class="hljs') === -1) {
+      if (previousLine.html && previousLine.html.indexOf('class="hljs') === -1) {
         try {
           previousLine.html = highlight(d.language, previousLine.text, true).value;
         } catch (e) {}
@@ -97,7 +97,7 @@ function loadDiagnostic(context: BuildContext, tsDiagnostic: ts.Diagnostic) {
         errorLength: -1
       };
 
-      if (nextLine.html.indexOf('class="hljs') === -1) {
+      if (nextLine.html && nextLine.html.indexOf('class="hljs') === -1) {
         try {
           nextLine.html = highlight(d.language, nextLine.text, true).value;
         } catch (e) {}