Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate hide event when user changes field #68

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

jcesarmobile
Copy link
Member

iOS keyboard always calls willHide, even when user changes the input field and there is no visible disappear/appear animations.

This PR uses a timer that is disabled if willShow is called right after willHide, so it doesn't send the event.

@mlynch mlynch merged commit becaa5b into ionic-team:master Feb 4, 2019
@jcesarmobile jcesarmobile deleted the hide-timer branch February 4, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants