Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): platforms api #4255

Merged
merged 23 commits into from
May 3, 2021
Merged

feat(core): platforms api #4255

merged 23 commits into from
May 3, 2021

Conversation

IT-MikeS
Copy link
Contributor

Start of a more clean platforms api, for adding and setting platforms. Addresses #4243

@IT-MikeS IT-MikeS marked this pull request as ready for review March 2, 2021 16:36
@adamdbradley adamdbradley requested a review from thomasvidas May 3, 2021 14:16
@adamdbradley
Copy link
Contributor

Since this PR there has been a significant internal update to how the native bridge works. Overall I think it's a good update, but would rather not rename any of the public APIs we already have established. Would you be able to rebase from master and not rename any of the public APIs? Thanks

IT-MikeS and others added 17 commits May 3, 2021 14:29
@IT-MikeS
platforms api init
67e9f04
@IT-MikeS
fix: wrong interface in defs.
dd7ae98
@IT-MikeS
fix: missed a default declare
ffd67f0
@jcesarmobile
fix(cli): filter targets without id from run device list (#4397)
c5923a9
@carlpoole
feat(android): ability to add listeners to the Capacitor WebView (#4405)
8980938
@carlpoole
fix(android): resolve issue with activity result API registration for…
0c0b8f0 
… fragments (#4402)
@jcesarmobile
chore(cli): Update plist dependency (#4458)
9d97b1a
@jcesarmobile
feat(cli): Add signup prompt on first init (#4440)
11d9b43
@jcesarmobile
fix(ios): put cancel button of confirm/prompt on the left (#4464)
513c5aa
@jcesarmobile
fix(cli): Allow prereleases on node version check (#4469)
7a3a990
@jcesarmobile
fix(ios): fire resume/pause events if no cordova plugins installed (#…
f2645da 
…4467)
@IT-MikeS
Merge branch 'add-platform-api' of https://github.com/IT-MikeS/capacitor
947e350 
 into add-platform-api
@IT-MikeS
Merge pull request #5 from ionic-team/main
ade3d9e 
merge main/upstream
@IT-MikeS
platforms api init
7d17064
@IT-MikeS
Merge branch 'add-platform-api' of https://github.com/IT-MikeS/capacitor
a91047a 
 into add-platform-api
@IT-MikeS
chore: clean
68becd6
@IT-MikeS
chore: remove events file
8602b3c
@IT-MikeS
Copy link
Contributor Author

IT-MikeS commented May 3, 2021

Did a rebase and a quick clean up

@thomasvidas
Copy link
Contributor

Looks great! If you need any help with getting https://github.com/capacitor-community/electron/ updated I'm happy to help. Just DM me on the community slack 😄

@thomasvidas thomasvidas merged commit 7d62713 into ionic-team:main May 3, 2021
@IT-MikeS
Copy link
Contributor Author

IT-MikeS commented May 3, 2021

Looks great! If you need any help with getting https://github.com/capacitor-community/electron/ updated I'm happy to help. Just DM me on the community slack 😄

Thanks! I'm pretty well done with the update but if anything comes up I'll be sure to take you up on that 😁

@IT-MikeS IT-MikeS deleted the add-platform-api branch May 3, 2021 19:40
This was referenced May 3, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdbradley adamdbradley adamdbradley left review comments

@thomasvidas thomasvidas thomasvidas approved these changes

@elylucas elylucas Awaiting requested review from elylucas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IT-MikeS @adamdbradley @thomasvidas @jcesarmobile @carlpoole