Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): resolve undefined for both checkPermissions and requestPermissions by default #3855

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

carlpoole
Copy link
Member

For platform consistency. Changes the result of checkPermissions and requestPermissions to resolve undefined when no permissions are defined on the plugin.

@carlpoole carlpoole requested review from imhoffd and ikeith November 24, 2020 16:41
@carlpoole carlpoole changed the title fix(android): resolve undefined for both checkPermissions and requestPermissions fix(android): resolve undefined for both checkPermissions and requestPermissions by default Nov 24, 2020
@carlpoole carlpoole changed the title fix(android): resolve undefined for both checkPermissions and requestPermissions by default refactor(android): resolve undefined for both checkPermissions and requestPermissions by default Nov 24, 2020
@imhoffd imhoffd changed the title refactor(android): resolve undefined for both checkPermissions and requestPermissions by default fix(android): resolve undefined for both checkPermissions and requestPermissions by default Nov 24, 2020
@carlpoole carlpoole merged commit 383f62b into main Nov 24, 2020
@carlpoole carlpoole deleted the perm-default branch November 24, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants