Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cordova plugins without "cordova" key in package.json are not recognized #338

Closed
DavidStrausz opened this issue Mar 15, 2018 · 0 comments
Closed
Assignees

Comments

@DavidStrausz
Copy link

Because of this check:

if (meta.cordova) {

Some cordova plugins (like cordova-plugin-app-version) are not recognized by the capacitor CLI.

A quick fix would be to check for "cordova" in the key but thats probably not very practical because every package with cordova in its name (including platforms: cordova-ios) would be considered a valid candidate.

Also it would be nice to have the app-version-plugin functionality included in one of the capacitor-core plugins (maybe as part of the App plugin).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants