Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make Modal prompts accessible by screen readers #2310

Closed
1 of 4 tasks
datawaslost opened this issue Jan 9, 2020 · 3 comments
Closed
1 of 4 tasks

feat: Make Modal prompts accessible by screen readers #2310

datawaslost opened this issue Jan 9, 2020 · 3 comments

Comments

@datawaslost
Copy link

datawaslost commented Jan 9, 2020

Feature Request

Describe the Feature Request

Currently, using Modal.prompt() triggers an Accessibility warning when submitting to the Android Google Play Store, because the android:id​/custom​/EditText[0] item doesn't have a screen-readable label.

Platform Support Requested

  • Android
  • iOS
  • Electron
  • Web

Describe Preferred Solution

Add an inputLabel property to Modal PromptOptions, and implement this label in the Modal prompt.

Related Code

let promptRet = await Modals.prompt({
	title: 'Title',
	message: "Message"
});

Additional Context

From Google's Pre-Launch Report:

"This item may not have a label readable by screen readers."
https://support.google.com/accessibility/android/answer/7158690

Tested on:
Moto G4 Play
Android 6.0
English (United States)
720 × 1280
320

@jcesarmobile
Copy link
Member

does the warning still appear if you use inputPlaceholder?

But just noticed the inputPlaceholder is a text and not a real placeholder, I've reported it in a separate issue.

#2339

@jcesarmobile jcesarmobile added the needs reply needs reply from the user label Jan 15, 2020
@jcesarmobile
Copy link
Member

Closing since there was no response, I think using inputPlaceholder should be enough to get rid of the warning.
But as I said, it should be a placeholder and not text, but I reported that already and will use that issue to fix it.

@jcesarmobile jcesarmobile removed the needs reply needs reply from the user label Feb 19, 2020
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 12, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants