Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gradle variables for setting the library versions #227

Closed
jcesarmobile opened this issue Mar 1, 2018 · 2 comments · Fixed by #2534
Closed

Use gradle variables for setting the library versions #227

jcesarmobile opened this issue Mar 1, 2018 · 2 comments · Fixed by #2534

Comments

@jcesarmobile
Copy link
Member

jcesarmobile commented Mar 1, 2018

Right now we are replacing the library versions on the build.gradle with javascript, but gradle actually supports the variables, so maybe we can create the variables from plugin.xml but let users overwrite them in the build.gradle instead of using plugin.xml or package.json Cordova variables

https://medium.com/@ivan_m/use-variables-to-manage-gradle-android-dependencies-library-version-numbers-92f0e362a2fc

Related PR where we replace the variables: #222

@jcesarmobile
Copy link
Member Author

Related #206

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 12, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Capacitor, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants