Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): event listener is not retained if was removed and added again #2095

Merged
merged 1 commit into from
Oct 24, 2019
Merged

fix(ios): event listener is not retained if was removed and added again #2095

merged 1 commit into from
Oct 24, 2019

Conversation

JohanVase
Copy link
Contributor

…eting a listener

@johan-mjolner johan-mjolner mentioned this pull request Oct 24, 2019
Closed
4 tasks
jcesarmobile
jcesarmobile approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@jcesarmobile jcesarmobile changed the title bug fix 2094: event listener is not notified even though event should be retained fix(ios): event listener is not retained if was removed and added again Oct 24, 2019
@jcesarmobile jcesarmobile merged commit fb97d06 into ionic-team:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohanVase @jcesarmobile @johan-mjolner