Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): return proper mimeType for .mjs files #2017

Merged
merged 1 commit into from
Oct 15, 2019
Merged

fix(android): return proper mimeType for .mjs files #2017

merged 1 commit into from
Oct 15, 2019

Conversation

cho45
Copy link
Contributor

@cho45 cho45 commented Oct 1, 2019

Some node modules provides ES module script with .mjs extension.

@jcesarmobile jcesarmobile changed the title .mjs is ES module fix(android): return proper mimeType for .mjs files Oct 15, 2019
jcesarmobile
jcesarmobile approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@jcesarmobile jcesarmobile merged commit b7fc6c8 into ionic-team:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cho45 @jcesarmobile