Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android template): drop orphaned file provider authority variable #1975

Merged
merged 2 commits into from
Sep 24, 2019

Conversation

zyniq82
Copy link
Contributor

@zyniq82 zyniq82 commented Sep 18, 2019

This re-instates what was done in 94b72cc, undone in e048d2b and later "fixed" in 1642584, which orphaned the fileprovider_authority variable in strings.xml.

As I'm not an Android developer, I'm not sure if the proper fix is to do what I just did now, re-instating the reference to the fileprovider_authority variable, or if it's better to keep AndroidManifest.xml unchanged and instead just remove the fileprovider_authority variable from strings.xml.

This re-instates what was done in 94b72cc, undone in e048d2b and later
'fixed' in 1642584, which orphaned 'fileprovider_authority' in strings.xml.
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to remove the fileprovider_authority from strings.xml as is unused.
Having ${applicationId} in the AndroidManifest.xml is better as it will pick changes on the application id without changing anything else.

@zyniq82 zyniq82 changed the title fix(android template): re-instate reference to file provider authority variable fix(android template): drop orphaned file provider authority variable Sep 24, 2019
@zyniq82
Copy link
Contributor Author

zyniq82 commented Sep 24, 2019

I've updated as requested, so now the only change is simply dropping the orphaned fileprovider_authority variable from strings.xml.

I've also updated the pull request title to better reflect the change.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@jcesarmobile jcesarmobile merged commit ed6647b into ionic-team:master Sep 24, 2019
@zyniq82 zyniq82 deleted the file-provider-reference-fix branch September 24, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants