feat(device): model now reflects exact model on iOS #929
Conversation
There was a problem hiding this comment.
For the simulator it's returning arm64 (on M1 macs), I think the model check should see if the device is a simulator with the #if targetEnvironment(simulator) macro and return the old UIDevice.current.model instead or maybe UIDevice.current.model + " Simulator", despite it's not gives the real mode I think it's better to get "iPhone" or "iPhone Simulator" than "arm64".
|
Good call, I like the idea of falling back to |
device/ios/Plugin/DevicePlugin.swift
Outdated
| @@ -24,6 +24,7 @@ public class DevicePlugin: CAPPlugin { | |||
| let diskFree = implementation.getFreeDiskSize() ?? 0 | |||
| let realDiskFree = implementation.getRealFreeDiskSize() ?? 0 | |||
| let diskTotal = implementation.getTotalDiskSize() ?? 0 | |||
| let modelName = isSimulator ? ProcessInfo().environment["SIMULATOR_MODEL_IDENTIFIER"]! + " Simulator" : implementation.getModelName() | |||
There was a problem hiding this comment.
Don’t force unwrap. I thought we had a lint rule to prevent it, but looks like we don’t.
Also, now that we can get the actual name I don’t think the model should contain the “Simulator” part, if users need to know if it’s a simulator they can check the “isVirtual” property
closes: #804
This is a feature for the plugin when released along side Capacitor 4 as it's a breaking change.
This work is derived from the work done by @robingenz on their PR #809