Network #8
Merged
Network #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imhoffd
reviewed
Aug 14, 2020
imhoffd
reviewed
Aug 17, 2020
imhoffd
reviewed
Aug 17, 2020
Co-authored-by: Dan Imhoff <[email protected]>
carlpoole
reviewed
Aug 18, 2020
carlpoole
reviewed
Aug 19, 2020
network/android/src/main/java/com/capacitorjs/plugins/network/Network.java
Outdated
Show resolved
Hide resolved
imhoffd
reviewed
Aug 19, 2020
jcesarmobile
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Looks good.
My only concern are the iOS tests. It tests that the connection is wifi, so it fails if run locally without internet connection.
I guess it won't fail on the CI since it needs to have connection to work and on simulators the connection is always wifi.
I guess we can delete or change them in the future if something changes, and we should have in mind that when testing locally we have to be connected or they will fail.
jcesarmobile
requested changes
Aug 28, 2020
Co-authored-by: jcesarmobile <[email protected]>
Co-authored-by: jcesarmobile <[email protected]>
Co-authored-by: jcesarmobile <[email protected]>
Co-authored-by: jcesarmobile <[email protected]>
jcesarmobile
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Looks good to me.
But @dwieeb, can you review the web.ts as it uses declare var window: any; and you told Carl in another PR to not use something similar?
imhoffd
reviewed
Aug 31, 2020
Co-authored-by: Dan Imhoff <[email protected]>
imhoffd
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress