Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(filesystem): support Library directory #666

Merged
merged 15 commits into from
Jan 11, 2022
Merged

feat(filesystem): support Library directory #666

merged 15 commits into from
Jan 11, 2022

Conversation

robingenz
Copy link
Contributor

Resolves #38

@robingenz
Copy link
Contributor Author

This also resolves ionic-team/capacitor#3073 and https://forum.ionicframework.com/t/capacitor-filesystem-plugin-accessing-ios-library-directory/194082.

@robingenz
Copy link
Contributor Author

Is there anything I can do to help with reviewing? Do you need any additional information or should I do any special tests?

jcesarmobile
jcesarmobile approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@jcesarmobile jcesarmobile merged commit ce7ee95 into ionic-team:main Jan 11, 2022
@robingenz robingenz deleted the robingenz/ios-library-directory branch January 11, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Library directory on iOS
3 participants
@robingenz @jcesarmobile @rgmfe4