Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(splash-screen): Make splash work in apps that use scenes #631

Merged
merged 4 commits into from
Dec 6, 2021
Merged

feat(splash-screen): Make splash work in apps that use scenes #631

merged 4 commits into from
Dec 6, 2021

Conversation

RishatShamsutdinov
Copy link
Contributor

On iOS 13 there is scenes (UIScene). When you're using scenes, the window property of the UIApplicationDelegate is nil.

@RishatShamsutdinov
Fix issue with scenes on iOS 13+
641a907 
On iOS 13 there is scenes (`UIScene`). When you're using scenes, the `window` property of the `UIApplicationDelegate` is `nil`.
@jcesarmobile
Merge branch 'main' into patch-1
717a174
@jcesarmobile
Use key window and don't force unwrap
244e794
@jcesarmobile
Merge branch 'patch-1' of https://github.com/RishatShamsutdinov/capac…
9701b0d 
…itor-plugins into patch-1
jcesarmobile
jcesarmobile approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've made some minor changes, one for making sure the window we get is the key window, and another to avoid the force unwrap of the window.

@jcesarmobile jcesarmobile changed the title Fix issue with scenes on iOS 13+ feat(splash-screen): Make splash work in apps that use scenes Dec 6, 2021
@jcesarmobile jcesarmobile mentioned this pull request Dec 6, 2021
Closed
@jcesarmobile jcesarmobile merged commit cf0d214 into ionic-team:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RishatShamsutdinov @jcesarmobile