feat(geolocation): Throw error if location is disabled #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpoole
approved these changes
Sep 1, 2021
carlpoole
added a commit
that referenced
this pull request
Sep 1, 2021
* docs(browser): Add clarifications to browser events (#560) * feat(storage): make StorageConfiguration init public (#532) * fix(filesystem): allow copy if from is not parent of to (#546) Co-authored-by: jcesarmobile <[email protected]> * fix(camera): cleanup camera images if not needed (#563) * fix(camera): return original image if editing is cancelled (#566) * fix(camera): return original image if editing is cancelled * fix(camera): Fix allowEdit: true when picking from photos * fix(camera): Resize not respecting aspect ratio on iOS (#568) * chore: adding stuff to deploy plugins to cocoapods * chore: adding npm install to script * chore: updating source to point to proper tag * chore: turning lerna concurrency to 1 for cocoapod builds * chore(android): native library publishing task to test (#575) * fix(local-notifications): Throw errors if missing mandatory channel fields (#577) * fix(push-notifications): Throw errors if missing mandatory channel fields (#576) * chore: adding manual task to deploy plugins to cocoapods * docs(notifications): Add links to explain the Android importance and visibility values (#584) * chore: Correct sources path in podspec (#586) * chore: fixing action sheet podspec * feat(geolocation): Throw error if location is disabled (#589) * fix: Correct missing source_files path (#590) * chore: adding full path to podspecs for cocoapods deploy (#591) * chore(release): publish [skip ci] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] - @capacitor/[email protected] Co-authored-by: jcesarmobile <[email protected]> Co-authored-by: fadoscha <[email protected]> Co-authored-by: Tachibana Shin <[email protected]> Co-authored-by: Max Lynch <[email protected]> Co-authored-by: Ely Lucas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By checking
isLocationEnabledinstead of relying onisLocationAvailable, we can throw an error if the location is disabled by the user, and not having theonLocationAvailabilitycallback workarounds the google play services bug that makesisLocationAvailable()to be always false.