ActionSheet #42
Merged
ActionSheet #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't update this PR because I wasn't sure if you were working on the web side and I didn't want to conflict with your changes, but at some point these changes should be applied (I forgot to publish the template, sorry): ionic-team/create-capacitor-plugin@75f77f4 |
|
I’m not working on the web side, at the moment it’s like it was in Modals plugin and requires pwa-elements. Not sure if Adam will work on it or if can be merged as is and update in the future. |
This comment has been minimized.
This comment has been minimized.
carlpoole
approved these changes
Sep 25, 2020
ikeith
approved these changes
Sep 25, 2020
imhoffd
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's draft PR because web implementation might be redone.