Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(push-notifications): proper return of push notification object properties #349

Merged
merged 4 commits into from
Apr 19, 2021
Merged

fix(push-notifications): proper return of push notification object properties #349

merged 4 commits into from
Apr 19, 2021

Conversation

theproducer
Copy link
Contributor

  • Renames extra back to data
  • Remove actionTypeId and attachments
  • Adds back subtitle and badge

closes: #332

@theproducer theproducer changed the title Fix(push-notifications) Fixing properties on returned push notification object Fix(push-notifications): Fixing properties on returned push notification object Apr 16, 2021
jcesarmobile
jcesarmobile reviewed Apr 19, 2021
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sound wasn't on Capacitor 2.x neither, any reason to leave it here?

@theproducer
Copy link
Contributor Author

sound wasn't on Capacitor 2.x neither, any reason to leave it here?

Nope - at least as far as I am aware.

It looks like right at the start of the port to Cap 3, properties from local and push notifications were melded together mistakenly or something.

jcesarmobile
jcesarmobile requested changes Apr 19, 2021
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the return there is a
let notificationRequest = notificationRequestLookup[request.identifier] ?? [:] line that is no longer used, can you delete it?

@jcesarmobile jcesarmobile changed the title Fix(push-notifications): Fixing properties on returned push notification object fix(push-notifications): proper return of push notification object properties Apr 19, 2021
@jcesarmobile jcesarmobile merged commit 733fc06 into main Apr 19, 2021
@jcesarmobile jcesarmobile deleted the push-notifications-data-extra branch April 19, 2021 16:09
hmaretic24 pushed a commit to hmaretic24/capacitor-plugins that referenced this pull request Jan 20, 2023
@theproducer
fix(push-notifications): proper return of push notification object pr…
c2f1407 
…operties (ionic-team#349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: PushNotificationSchema on ios has 'extra' instead of 'data'
2 participants
@theproducer @jcesarmobile