Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(local-notifications): extra not being returned on notification events #340

Merged
merged 2 commits into from
Apr 12, 2021
Merged

fix(local-notifications): extra not being returned on notification events #340

merged 2 commits into from
Apr 12, 2021

Conversation

jcesarmobile
Copy link
Member

extra was not being returned because it needed to be coerced, but also because userInfo was split into cap_schedule and cap_extra.

So reused makePendingNotificationRequestJSObject as it was already handling cap_schedule and cap_extra to generate the notification of makeNotificationRequestJSObject

closes #337

@vitorlopez
Copy link

vitorlopez commented Apr 9, 2021 •
edited
Loading

Thanks for this PR!

theproducer
theproducer approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@theproducer theproducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works.

@jcesarmobile jcesarmobile merged commit 5b03a7f into main Apr 12, 2021
@jcesarmobile jcesarmobile deleted the fix-extra branch April 12, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theproducer theproducer theproducer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jcesarmobile @vitorlopez @theproducer