feat(app): Add canGoBack to backButton event. #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #130 (comment) |
|
Weird, lint seems to have passed on my previous commit just 10 minutes before, and my new commit only adds the auto-generated docs. It also seems to say '@capacitor/text-zoom' so I'm guessing it's just flaky? Is there any way to re-run the lint? |
|
Got lint to re-run and clear the PR! |
|
@imhoffd Any feedback? I know you guys are probably busy. Hopefully this small patch won't take long. |
jcesarmobile
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
canGoBack(boolean) status to the event object of thebackButtonevent on Android.This status isn't normally accessible from the JS side, but would be very useful if the app uses the browser history stack for handling navigation.