fix(filesystem): support writing files without scheme #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test app silently fails on copy and rename buttons because it tries to create a file without scheme and that's not supported.
This PR add support for writing files using file urls without a scheme (
file:///whateveris equivalent towhateverbut at the moment first one woks and second silently fail). All other file functions support file scheme and no scheme on file urls.With the PR, you can write files without having the
filescheme, and also fails if the user uses a scheme that is not supported (that was also silently failing)related to ionic-team/capacitor-testapp#102