feat(local-notifications): add more info to pending notifications #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imhoffd
reviewed
Jan 22, 2021
...roid/src/main/java/com/capacitorjs/plugins/localnotifications/LocalNotificationSchedule.java
Outdated
Show resolved
Hide resolved
carlpoole
reviewed
Jan 23, 2021
...roid/src/main/java/com/capacitorjs/plugins/localnotifications/LocalNotificationSchedule.java
Outdated
Show resolved
Hide resolved
|
I think that instead of editing the LocalNotificationDescriptor type, they should return LocalNotificationSchema type. Not really sure if it’s worth it for schedule since it will just return what the user sent. |
added 6 commits
January 28, 2021 16:29
…tionSchema in PendingResult
# Conflicts: # local-notifications/android/src/main/java/com/capacitorjs/plugins/localnotifications/LocalNotification.java # local-notifications/ios/Plugin/LocalNotificationsPlugin.swift # local-notifications/src/web.ts
This was referenced Jan 29, 2021
...ions/android/src/main/java/com/capacitorjs/plugins/localnotifications/LocalNotification.java
Show resolved
Hide resolved
ikeith
reviewed
Jan 29, 2021
carlpoole
approved these changes
Feb 2, 2021
ikeith
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more useful information to the array of returned pending notification.
closes #193