Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(camera): return file URL for path, not system path #170

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Jan 1, 2021

Capacitor 2 used a file:// URL for the path to the photo (https://github.com/ionic-team/capacitor/blob/2.x/ios/Capacitor/Capacitor/Plugins/Camera.swift#L390). It looks like this was changed during a refactor. This PR returns the absoluteString which includes the file protocol to avoid a breaking change in the camera plugin when people update from v2 to v3.

@imhoffd imhoffd requested a review from ikeith January 1, 2021 00:00
@imhoffd imhoffd merged commit 8a9e5c3 into main Jan 4, 2021
@imhoffd imhoffd deleted the fix-camera-path branch January 4, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants