Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: angular toolkit should work in angular 14 #474

Closed
4 of 7 tasks
henkkelder opened this issue Jul 15, 2022 · 6 comments
Closed
4 of 7 tasks

bug: angular toolkit should work in angular 14 #474

henkkelder opened this issue Jul 15, 2022 · 6 comments
Labels

Comments

@henkkelder
Copy link
Contributor

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x
  • Nightly

Current Behavior

live reload using cordova and angular 14 does no longer work.

> ng.cmd run app:ionic-cordova-serve --host=localhost --port=8100 --platform=browser
[ng] This version of CLI is only compatible with Angular versions ^13.0.0 || ^13.3.0-rc.0,
[ng] but Angular version 14.0.6 was found instead.
[ng]
[ng] Please visit the link below to find instructions on how to update Angular.
[ng] https://update.angular.io/
[ng]

[ERROR] ng has unexpectedly closed (exit code 3).

Most likely cause is that @ionic/cordova-builders is not updated to use Angular 14.

Expected Behavior

Live reload should work.

Steps to Reproduce

Try to run any given cordova/angular 14 app with the -l option.

Code Reproduction URL

No response

Ionic Info

Ionic:

   Ionic CLI                     : 6.20.1 (C:\Users\xxxxxx\AppData\Roaming\npm\node_modules\@ionic\cli)
   Ionic Framework               : @ionic/angular 6.1.14
   @angular-devkit/build-angular : 14.0.6
   @angular-devkit/schematics    : 14.0.6
   @angular/cli                  : 14.0.6
   @ionic/angular-toolkit        : 6.1.0

Cordova:

   Cordova CLI       : 11.0.0
   Cordova Platforms : android 11.0.0, browser 6.0.0
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 5.0.0, (and 21 other plugins)

Utility:

   cordova-res : 0.15.4
   native-run  : 1.6.0

System:

   Android SDK Tools : 26.1.1 (C:\Users\xxxxxx\AppData\Local\Android\Sdk)
   NodeJS            : v16.15.1 (C:\Program Files\nodejs\node.exe)
   npm               : 8.14.0
   OS                : Windows 10

Additional Information

I have reported the issue also at https://github.com/ionic-team/[angular-toolkit](https://github.com/ionic-team/angular-toolkit) but that doesn't seem t be monitored.

@ionitron-bot ionitron-bot bot added the triage label Jul 15, 2022
@liamdebeasi liamdebeasi transferred this issue from ionic-team/ionic-framework Jul 15, 2022
@liamdebeasi
Copy link
Contributor

Thanks for the issue. It looks like the dependencies for the schematics and cordova-builders packages need to be updated for Angular 14:

Schematics:

"@angular-devkit/architect": "^0.1300.1",
"@angular-devkit/build-angular": "^13.0.1",
"@angular-devkit/core": "^13.0.1",
"@angular-devkit/schematics": "^13.0.1",
"@schematics/angular": "^13.0.1",

Cordova Builders:
"@angular-devkit/core": "^13.0.1",

cc @mhartington

@liamdebeasi liamdebeasi changed the title bug: bug: angular toolkit should work in angular 14 Jul 15, 2022
@Gargamil
Copy link

any plans for an update? Need it too..

@henkkelder
Copy link
Contributor Author

When will this result in a release? Or Tag? Or is there another way how to use this fix?

@mhartington
Copy link
Contributor

Didn't release on Friday because...well it's a friday.

But it's out now!
Update to V7

@henkkelder
Copy link
Contributor Author

And it works :-)

@chrux
Copy link

chrux commented Jul 20, 2022

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants