fix(utils) always initialize scripts array #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkgroenen
force-pushed
the
fix-empty-scripts-check
branch
from
fde2d49
to
a412b1d
Compare
mhartington
approved these changes
Jan 8, 2020
|
Looks good! Thanks for the PR |
imhoffd
pushed a commit
that referenced
this pull request
Jan 10, 2020
Ionitron
added a commit
that referenced
this pull request
Jan 13, 2020
## [2.1.2](v2.1.1...v2.1.2) (2020-01-13) ### Bug Fixes * **cordova:** add cordova.js to index.html even without scripts array ([c8bb37b](c8bb37b)), closes [#188](#188)
|
🎉 This issue has been resolved in version 2.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
wand1252
added a commit
to wand1252/angular-toolkit-develop
that referenced
this pull request
Aug 31, 2022
## [2.1.2](ionic-team/angular-toolkit@v2.1.1...v2.1.2) (2020-01-13) ### Bug Fixes * **cordova:** add cordova.js to index.html even without scripts array ([c8bb37b](ionic-team/angular-toolkit@c8bb37b)), closes [#188](ionic-team/angular-toolkit#188)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project we were experiencing issues of a missing
cordova.jsfile after upgrading to Angular 8. After some searching around it seems like we were having the same issue as mentioned in #179 .Thing is: we were already using the latest version of angular-toolkit, which included the fix 0aeec97 .
It seems like the fix only initializes the
scriptsarray with an empty array whenconsolelogsis used. In our project it isn't, which causes thescriptsarray to remainnulland thus preventing thecordova.jsfrom being injected.consolelogsstatement resolves the issue of a missingcordova.js.