Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exports.deprecate to util.deprecate in example #1535

Closed
wants to merge 2 commits into from
Closed

Update exports.deprecate to util.deprecate in example #1535

wants to merge 2 commits into from

Conversation

enaqx
Copy link
Contributor

@enaqx enaqx commented Apr 27, 2015

No description provided.

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Apr 27, 2015
@Fishrock123
Copy link
Contributor

LGTM

1 similar comment
@evanlucas
Copy link
Contributor

LGTM

@@ -438,11 +438,13 @@ through the `constructor.super_` property.

Marks that a method should not be used any more.

exports.puts = exports.deprecate(function() {
var util = require('utils');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require('util')

@julianduque
Copy link
Contributor

@enaqx LGTM

Can you squash your commits in only one following the contributing guide to something like:

doc: update exports.deprecate to util.deprecate in example

Thanks!

Fishrock123 pushed a commit that referenced this pull request Apr 28, 2015
PR-URL: #1535
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Julian Duque <[email protected]>
@Fishrock123
Copy link
Contributor

Thanks, landed in e55fdc4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants