doc: fix util.isObject documentation #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
util
| @@ -328,7 +328,7 @@ Returns `true` if the given "object" is `undefined`. `false` otherwise. | |||
|
|
|||
| ## util.isObject(object) | |||
|
|
|||
| Returns `true` if the given "object" is strictly an `Object`. `false` otherwise. | |||
| Returns `true` if the given "object" is strictly an `Object` __and__ not a `Function`. `false` otherwise. | |||
There was a problem hiding this comment.
Can you wrap this at 80 columns?
|
LGTM with style nit. |
Fishrock123
force-pushed
the
fix-isObject-docs
branch
from
731136d
to
99b0db9
Compare
|
Updated. |
|
LGTM |
|
Regarding the deprecation, I don't see any reason to postpone it beyond 2.0.0; we'd just be digging ourselves in a bigger hole if we plan on eventually removing it. I'd love to see lots of things deprecated before 2.0.0 to clean up the API, as there are a few function references and stuff that I think many would like to see deprecated and removed but they're just being kept. Though they may not be removed for some time, it'd free us up to remove them sooner rather than later. +1 for this PR |
Proposed functionality fix containing prior discussion: nodejs#822 Fixes: nodejs#743 PR-URL: nodejs#1295 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brendan Ashworth <[email protected]>
Fishrock123
force-pushed
the
fix-isObject-docs
branch
from
99b0db9
to
245ba1d
Compare
|
Thanks! @brendanashworth I'm going to open a new issue/pr for deprecation |
This was referenced Mar 31, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts #743 to rest for good.
The change to fix the functionality would be too radical.
Replaces #822 (arguments for this are also contained in that thread).
These functions should probably be deprecated later. Maybe post-2.0.0?