Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed blockly definitions, dropped node16, eslint and minor fixes #455

Merged
merged 11 commits into from
Jul 13, 2024
Merged

Conversation

klein0r
Copy link
Contributor

@klein0r klein0r commented Jun 7, 2024

No description provided.

@@ -242,7 +240,7 @@
ack = undefined;
}

if (typeof state !== 'object' || state === null || state === undefined) state = {val: state};
if (typeof state !== 'object' || state === null || state === undefined) state = { val: state };

Check warning

Code scanning / CodeQL

Comparison between inconvertible types Warning test

Variable 'state' is of type date, object or regular expression, but it is compared to
'undefined'
of type undefined.
@@ -279,7 +277,7 @@
ack = undefined;
}

if (typeof state !== 'object' || state === null || state === undefined) state = {val: state};
if (typeof state !== 'object' || state === null || state === undefined) state = { val: state };

Check warning

Code scanning / CodeQL

Comparison between inconvertible types Warning test

Variable 'state' is of type date, object or regular expression, but it is compared to
'undefined'
of type undefined.
@@ -560,7 +558,7 @@
if (pattern && pattern !== '*') {
params = {
startkey: pattern.replace('*', ''),
endkey: pattern.replace('*', '\u9999')
endkey: pattern.replace('*', '\u9999')

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High test

This replaces only the first occurrence of '*'.
let adapterName = path.normalize(rootDir).replace(/\\/g, '/').split('/');
adapterName = adapterName[adapterName.length - 2];
adapterName = adapterName[adapterName.length - 2];

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning test

The value assigned to adapterName here is unused.
@GermanBluefox GermanBluefox merged commit ca89650 into ioBroker:master Jul 13, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants